From: | Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
---|---|
To: | Simon Riggs <simon(at)2ndQuadrant(dot)com> |
Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, List pgsql-patches <pgsql-patches(at)postgresql(dot)org> |
Subject: | Re: [HACKERS] Infrastructure changes for recovery |
Date: | 2008-09-12 19:31:44 |
Message-ID: | 20080912193144.GJ8854@alvh.no-ip.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers pgsql-patches |
Simon Riggs wrote:
>
> On Fri, 2008-09-12 at 14:14 -0400, Alvaro Herrera wrote:
> > Simon Riggs wrote:
> >
> > > --- 5716,5725 ----
> > > CheckpointStats.ckpt_sync_end_t,
> > > &sync_secs, &sync_usecs);
> > >
> > > ! elog(LOG, "%s complete: wrote %d buffers (%.1f%%); "
> > > "%d transaction log file(s) added, %d removed, %d recycled; "
> > > "write=%ld.%03d s, sync=%ld.%03d s, total=%ld.%03d s",
> > > + (checkpoint ? " checkpoint" : "restartpoint"),
> > > CheckpointStats.ckpt_bufs_written,
> > > (double) CheckpointStats.ckpt_bufs_written * 100 / NBuffers,
> > > CheckpointStats.ckpt_segs_added,
> >
> > Very minor nit: this really needs a rework.
>
> All I changed was the word "restartpoint"... its otherwise identical to
> existing message. I'd rather not change that.
The new message is not translatable, the original was.
--
Alvaro Herrera http://www.CommandPrompt.com/
The PostgreSQL Company - Command Prompt, Inc.
From | Date | Subject | |
---|---|---|---|
Next Message | Alvaro Herrera | 2008-09-12 19:49:15 | Re: [Review] Tests citext casts by David Wheeler. |
Previous Message | Ron Mayer | 2008-09-12 19:09:35 | Re: Proposed patch: make SQL interval-literal syntax work per spec |
From | Date | Subject | |
---|---|---|---|
Next Message | Simon Riggs | 2008-09-12 19:55:25 | Re: [HACKERS] Infrastructure changes for recovery |
Previous Message | Simon Riggs | 2008-09-12 18:56:06 | Re: [HACKERS] Infrastructure changes for recovery |