Skip site navigation (1) Skip section navigation (2)

Re: [Review] pgbench duration option

From: ITAGAKI Takahiro <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp>
To: "Brendan Jurd" <direvus(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org
Cc: Ragnar <gnari(at)hive(dot)is>
Subject: Re: [Review] pgbench duration option
Date: 2008-09-08 08:59:41
Message-ID: 20080908174150.9839.52131E4D@oss.ntt.co.jp (view raw or flat)
Thread:
Lists: pgsql-hackers
Here is a revised version of the pgbench duration patch.
I merged some comments from Brendan and gnari.

"Brendan Jurd" <direvus(at)gmail(dot)com> wrote:

> >> Wouldn't this be better written as:
> >>   if ((duration > 0 && timer_exceeded) || st->cnt >= nxacts)
> >
> > sorry, but these do not lok as the same thing to me.
> > gnari

I used this condition expression here:
       if ((st->cnt >= nxacts && duration <= 0) || timer_exceeded)

Regards,
---
ITAGAKI Takahiro
NTT Open Source Software Center


Attachment: pgbench-duration_v3.patch
Description: application/octet-stream (8.6 KB)

In response to

Responses

pgsql-hackers by date

Next:From: Heikki LinnakangasDate: 2008-09-08 09:10:36
Subject: Re: Prototype: In-place upgrade v02
Previous:From: Zdenek KotalaDate: 2008-09-08 08:58:09
Subject: Re: hash index improving v3

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group