Skip site navigation (1) Skip section navigation (2)

Re: BUG #4374: pg_restore does not restore public schema comment

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Craig Ringer <craig(at)postnewspapers(dot)com(dot)au>, Daniel Migowski <dmigowski(at)ikoffice(dot)de>, pgsql-bugs(at)postgresql(dot)org
Subject: Re: BUG #4374: pg_restore does not restore public schema comment
Date: 2008-09-05 23:53:52
Message-ID: 200809052353.m85NrqZ16912@momjian.us (view raw or flat)
Thread:
Lists: pgsql-bugs
Tom Lane wrote:
> Craig Ringer <craig(at)postnewspapers(dot)com(dot)au> writes:
> > The issue actually appears to be that the comment on default schema like
> > `public' isn't dumped in the first place.
> 
> Hmm ... there is a specific exclusion in _printTocEntry to suppress
> dumping of either the CREATE SCHEMA command for "public" or its comment.
> I don't quite recall the reasoning [ digs... ]  Oh, here it is:
> http://archives.postgresql.org/pgsql-committers/2008-01/msg00212.php
> You can probably find some related discussion in the archives right
> before that, but the commit message is clear enough.
> 
> On the whole, since "public" is a quasi-built-in object, it doesn't seem
> like a very good idea to depend on being able to alter its properties.
> Why not attach your version comment to some other, entirely user-defined
> object?  "CREATE SCHEMA version" perhaps ...

I have added a comment in the source code about this.

-- 
  Bruce Momjian  <bruce(at)momjian(dot)us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

  + If your life is a hard drive, Christ can be your backup. +

In response to

pgsql-bugs by date

Next:From: Bruce MomjianDate: 2008-09-06 00:42:44
Subject: Re: BUG #4377: casting result of timeofday() to timestamp fails in some timezones
Previous:From: Rainer GlueckDate: 2008-09-05 08:22:54
Subject: Re: BUG #4398: Backslashes get escaped despite of backslash_quote=off

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group