Skip site navigation (1) Skip section navigation (2)

pgsql: Add a bunch of new error location reports to parse-analysis error

From: tgl(at)postgresql(dot)org (Tom Lane)
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Add a bunch of new error location reports to parse-analysis error
Date: 2008-09-01 20:42:46
Message-ID: 20080901204246.AB14C755325@cvs.postgresql.org (view raw or flat)
Thread:
Lists: pgsql-committers
Log Message:
-----------
Add a bunch of new error location reports to parse-analysis error messages.
There are still some weak spots around JOIN USING and relation alias lists,
but most errors reported within backend/parser/ now have locations.

Modified Files:
--------------
    pgsql/contrib/cube/expected:
        cube.out (r1.21 -> r1.22)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/contrib/cube/expected/cube.out?r1=1.21&r2=1.22)
        cube_1.out (r1.9 -> r1.10)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/contrib/cube/expected/cube_1.out?r1=1.9&r2=1.10)
        cube_2.out (r1.6 -> r1.7)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/contrib/cube/expected/cube_2.out?r1=1.6&r2=1.7)
    pgsql/contrib/seg/expected:
        seg.out (r1.13 -> r1.14)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/contrib/seg/expected/seg.out?r1=1.13&r2=1.14)
        seg_1.out (r1.4 -> r1.5)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/contrib/seg/expected/seg_1.out?r1=1.4&r2=1.5)
    pgsql/src/backend/bootstrap:
        bootparse.y (r1.92 -> r1.93)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/bootstrap/bootparse.y?r1=1.92&r2=1.93)
        bootstrap.c (r1.244 -> r1.245)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/bootstrap/bootstrap.c?r1=1.244&r2=1.245)
    pgsql/src/backend/catalog:
        namespace.c (r1.110 -> r1.111)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/catalog/namespace.c?r1=1.110&r2=1.111)
        toasting.c (r1.10 -> r1.11)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/catalog/toasting.c?r1=1.10&r2=1.11)
    pgsql/src/backend/commands:
        tablecmds.c (r1.264 -> r1.265)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/commands/tablecmds.c?r1=1.264&r2=1.265)
        trigger.c (r1.236 -> r1.237)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/commands/trigger.c?r1=1.236&r2=1.237)
    pgsql/src/backend/nodes:
        copyfuncs.c (r1.403 -> r1.404)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/nodes/copyfuncs.c?r1=1.403&r2=1.404)
        equalfuncs.c (r1.330 -> r1.331)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/nodes/equalfuncs.c?r1=1.330&r2=1.331)
        makefuncs.c (r1.59 -> r1.60)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/nodes/makefuncs.c?r1=1.59&r2=1.60)
        nodeFuncs.c (r1.31 -> r1.32)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/nodes/nodeFuncs.c?r1=1.31&r2=1.32)
        outfuncs.c (r1.337 -> r1.338)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/nodes/outfuncs.c?r1=1.337&r2=1.338)
        readfuncs.c (r1.213 -> r1.214)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/nodes/readfuncs.c?r1=1.213&r2=1.214)
    pgsql/src/backend/optimizer/util:
        plancat.c (r1.150 -> r1.151)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/optimizer/util/plancat.c?r1=1.150&r2=1.151)
        var.c (r1.78 -> r1.79)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/optimizer/util/var.c?r1=1.78&r2=1.79)
    pgsql/src/backend/parser:
        analyze.c (r1.378 -> r1.379)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/parser/analyze.c?r1=1.378&r2=1.379)
        gram.y (r2.620 -> r2.621)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/parser/gram.y?r1=2.620&r2=2.621)
        parse_agg.c (r1.82 -> r1.83)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/parser/parse_agg.c?r1=1.82&r2=1.83)
        parse_clause.c (r1.178 -> r1.179)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/parser/parse_clause.c?r1=1.178&r2=1.179)
        parse_coerce.c (r2.165 -> r2.166)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/parser/parse_coerce.c?r1=2.165&r2=2.166)
        parse_expr.c (r1.233 -> r1.234)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/parser/parse_expr.c?r1=1.233&r2=1.234)
        parse_func.c (r1.206 -> r1.207)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/parser/parse_func.c?r1=1.206&r2=1.207)
        parse_node.c (r1.102 -> r1.103)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/parser/parse_node.c?r1=1.102&r2=1.103)
        parse_relation.c (r1.134 -> r1.135)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/parser/parse_relation.c?r1=1.134&r2=1.135)
        parse_target.c (r1.163 -> r1.164)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/parser/parse_target.c?r1=1.163&r2=1.164)
        parse_type.c (r1.98 -> r1.99)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/parser/parse_type.c?r1=1.98&r2=1.99)
        parse_utilcmd.c (r2.16 -> r2.17)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/parser/parse_utilcmd.c?r1=2.16&r2=2.17)
        scan.l (r1.145 -> r1.146)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/parser/scan.l?r1=1.145&r2=1.146)
    pgsql/src/backend/rewrite:
        rewriteManip.c (r1.112 -> r1.113)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/rewrite/rewriteManip.c?r1=1.112&r2=1.113)
    pgsql/src/backend/tcop:
        utility.c (r1.297 -> r1.298)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/tcop/utility.c?r1=1.297&r2=1.298)
    pgsql/src/backend/utils/adt:
        ruleutils.c (r1.281 -> r1.282)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/utils/adt/ruleutils.c?r1=1.281&r2=1.282)
    pgsql/src/backend/utils/error:
        elog.c (r1.205 -> r1.206)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/utils/error/elog.c?r1=1.205&r2=1.206)
    pgsql/src/include/catalog:
        catversion.h (r1.481 -> r1.482)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/include/catalog/catversion.h?r1=1.481&r2=1.482)
    pgsql/src/include/nodes:
        makefuncs.h (r1.62 -> r1.63)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/include/nodes/makefuncs.h?r1=1.62&r2=1.63)
        parsenodes.h (r1.373 -> r1.374)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/include/nodes/parsenodes.h?r1=1.373&r2=1.374)
        primnodes.h (r1.140 -> r1.141)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/include/nodes/primnodes.h?r1=1.140&r2=1.141)
    pgsql/src/include/optimizer:
        var.h (r1.37 -> r1.38)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/include/optimizer/var.h?r1=1.37&r2=1.38)
    pgsql/src/include/parser:
        gramparse.h (r1.41 -> r1.42)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/include/parser/gramparse.h?r1=1.41&r2=1.42)
        parse_node.h (r1.55 -> r1.56)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/include/parser/parse_node.h?r1=1.55&r2=1.56)
        parse_relation.h (r1.57 -> r1.58)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/include/parser/parse_relation.h?r1=1.57&r2=1.58)
    pgsql/src/include/rewrite:
        rewriteManip.h (r1.46 -> r1.47)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/include/rewrite/rewriteManip.h?r1=1.46&r2=1.47)
    pgsql/src/include/utils:
        elog.h (r1.93 -> r1.94)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/include/utils/elog.h?r1=1.93&r2=1.94)
    pgsql/src/pl/plperl/expected:
        plperl.out (r1.12 -> r1.13)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/pl/plperl/expected/plperl.out?r1=1.12&r2=1.13)
    pgsql/src/pl/plpgsql/src:
        pl_comp.c (r1.129 -> r1.130)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/pl/plpgsql/src/pl_comp.c?r1=1.129&r2=1.130)
    pgsql/src/test/regress/expected:
        abstime.out (r1.16 -> r1.17)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/test/regress/expected/abstime.out?r1=1.16&r2=1.17)
        aggregates.out (r1.17 -> r1.18)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/test/regress/expected/aggregates.out?r1=1.17&r2=1.18)
        alter_table.out (r1.109 -> r1.110)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/test/regress/expected/alter_table.out?r1=1.109&r2=1.110)
        arrays.out (r1.39 -> r1.40)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/test/regress/expected/arrays.out?r1=1.39&r2=1.40)
        boolean.out (r1.13 -> r1.14)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/test/regress/expected/boolean.out?r1=1.13&r2=1.14)
        box.out (r1.11 -> r1.12)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/test/regress/expected/box.out?r1=1.11&r2=1.12)
        circle.out (r1.9 -> r1.10)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/test/regress/expected/circle.out?r1=1.9&r2=1.10)
        create_type.out (r1.16 -> r1.17)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/test/regress/expected/create_type.out?r1=1.16&r2=1.17)
        date.out (r1.6 -> r1.7)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/test/regress/expected/date.out?r1=1.6&r2=1.7)
        enum.out (r1.1 -> r1.2)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/test/regress/expected/enum.out?r1=1.1&r2=1.2)
        errors.out (r1.53 -> r1.54)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/test/regress/expected/errors.out?r1=1.53&r2=1.54)
        float4-exp-three-digits.out (r1.8 -> r1.9)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/test/regress/expected/float4-exp-three-digits.out?r1=1.8&r2=1.9)
        float4.out (r1.14 -> r1.15)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/test/regress/expected/float4.out?r1=1.14&r2=1.15)
        float8-exp-three-digits-win32.out (r1.9 -> r1.10)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/test/regress/expected/float8-exp-three-digits-win32.out?r1=1.9&r2=1.10)
        float8-small-is-zero.out (r1.12 -> r1.13)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/test/regress/expected/float8-small-is-zero.out?r1=1.12&r2=1.13)
        float8-small-is-zero_1.out (r1.6 -> r1.7)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/test/regress/expected/float8-small-is-zero_1.out?r1=1.6&r2=1.7)
        float8.out (r1.26 -> r1.27)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/test/regress/expected/float8.out?r1=1.26&r2=1.27)
        horology.out (r1.66 -> r1.67)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/test/regress/expected/horology.out?r1=1.66&r2=1.67)
        inet.out (r1.23 -> r1.24)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/test/regress/expected/inet.out?r1=1.23&r2=1.24)
        insert.out (r1.8 -> r1.9)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/test/regress/expected/insert.out?r1=1.8&r2=1.9)
        int2.out (r1.13 -> r1.14)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/test/regress/expected/int2.out?r1=1.13&r2=1.14)
        int4.out (r1.15 -> r1.16)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/test/regress/expected/int4.out?r1=1.15&r2=1.16)
        int8-exp-three-digits.out (r1.8 -> r1.9)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/test/regress/expected/int8-exp-three-digits.out?r1=1.8&r2=1.9)
        int8.out (r1.11 -> r1.12)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/test/regress/expected/int8.out?r1=1.11&r2=1.12)
        interval.out (r1.19 -> r1.20)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/test/regress/expected/interval.out?r1=1.19&r2=1.20)
        lseg.out (r1.9 -> r1.10)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/test/regress/expected/lseg.out?r1=1.9&r2=1.10)
        numeric.out (r1.22 -> r1.23)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/test/regress/expected/numeric.out?r1=1.22&r2=1.23)
        oid.out (r1.12 -> r1.13)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/test/regress/expected/oid.out?r1=1.12&r2=1.13)
        path.out (r1.6 -> r1.7)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/test/regress/expected/path.out?r1=1.6&r2=1.7)
        point.out (r1.17 -> r1.18)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/test/regress/expected/point.out?r1=1.17&r2=1.18)
        polygon.out (r1.13 -> r1.14)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/test/regress/expected/polygon.out?r1=1.13&r2=1.14)
        prepared_xacts.out (r1.5 -> r1.6)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/test/regress/expected/prepared_xacts.out?r1=1.5&r2=1.6)
        rangefuncs.out (r1.18 -> r1.19)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/test/regress/expected/rangefuncs.out?r1=1.18&r2=1.19)
        reltime.out (r1.9 -> r1.10)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/test/regress/expected/reltime.out?r1=1.9&r2=1.10)
        rowtypes.out (r1.11 -> r1.12)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/test/regress/expected/rowtypes.out?r1=1.11&r2=1.12)
        select_distinct_on.out (r1.4 -> r1.5)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/test/regress/expected/select_distinct_on.out?r1=1.4&r2=1.5)
        select_having.out (r1.10 -> r1.11)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/test/regress/expected/select_having.out?r1=1.10&r2=1.11)
        select_having_1.out (r1.4 -> r1.5)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/test/regress/expected/select_having_1.out?r1=1.4&r2=1.5)
        select_having_2.out (r1.2 -> r1.3)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/test/regress/expected/select_having_2.out?r1=1.2&r2=1.3)
        select_implicit.out (r1.16 -> r1.17)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/test/regress/expected/select_implicit.out?r1=1.16&r2=1.17)
        select_implicit_1.out (r1.8 -> r1.9)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/test/regress/expected/select_implicit_1.out?r1=1.8&r2=1.9)
        select_implicit_2.out (r1.5 -> r1.6)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/test/regress/expected/select_implicit_2.out?r1=1.5&r2=1.6)
        temp.out (r1.14 -> r1.15)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/test/regress/expected/temp.out?r1=1.14&r2=1.15)
        time.out (r1.13 -> r1.14)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/test/regress/expected/time.out?r1=1.13&r2=1.14)
        timestamp.out (r1.36 -> r1.37)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/test/regress/expected/timestamp.out?r1=1.36&r2=1.37)
        timestamptz.out (r1.30 -> r1.31)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/test/regress/expected/timestamptz.out?r1=1.30&r2=1.31)
        timetz.out (r1.8 -> r1.9)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/test/regress/expected/timetz.out?r1=1.8&r2=1.9)
        tinterval.out (r1.13 -> r1.14)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/test/regress/expected/tinterval.out?r1=1.13&r2=1.14)
        transactions.out (r1.17 -> r1.18)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/test/regress/expected/transactions.out?r1=1.17&r2=1.18)
        truncate.out (r1.17 -> r1.18)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/test/regress/expected/truncate.out?r1=1.17&r2=1.18)
        txid.out (r1.1 -> r1.2)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/test/regress/expected/txid.out?r1=1.1&r2=1.2)
        uuid.out (r1.3 -> r1.4)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/test/regress/expected/uuid.out?r1=1.3&r2=1.4)
        xml.out (r1.21 -> r1.22)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/test/regress/expected/xml.out?r1=1.21&r2=1.22)
        xml_1.out (r1.22 -> r1.23)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/test/regress/expected/xml_1.out?r1=1.22&r2=1.23)
    pgsql/src/test/regress/output:
        create_function_1.source (r1.31 -> r1.32)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/test/regress/output/create_function_1.source?r1=1.31&r2=1.32)

pgsql-committers by date

Next:From: User FxjrDate: 2008-09-01 20:58:26
Subject: npgsql - Npgsql2: [npgsql-open-discussion][1003946] RE: Connection leak
Previous:From: Heikki LinnakangasDate: 2008-09-01 18:53:03
Subject: pgsql: HeapTupleHeaderAdjustCmax made the incorrect assumption that the

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group