Skip site navigation (1) Skip section navigation (2)

pgsql: As noted by Andrew Gierth, there's really no need any more to

From: tgl(at)postgresql(dot)org (Tom Lane)
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: As noted by Andrew Gierth, there's really no need any more to
Date: 2008-07-26 19:15:35
Message-ID: 20080726191535.D2CBC754A86@cvs.postgresql.org (view raw or flat)
Thread:
Lists: pgsql-committers
Log Message:
-----------
As noted by Andrew Gierth, there's really no need any more to force a junk
filter to be used when INSERT or SELECT INTO has a plan that returns raw
disk tuples.  The virtual-tuple-slot optimizations that were put in place
awhile ago mean that ExecInsert has to do ExecMaterializeSlot, and that
already copies the tuple if it's raw (and does so more efficiently than
a junk filter, too).  So get rid of that logic.  This in turn means that
we can throw away ExecMayReturnRawTuples, which wasn't used for any other
purpose, and was always a kluge anyway.

In passing, move a couple of SELECT-INTO-specific fields out of EState
and into the private state of the SELECT INTO DestReceiver, as was foreseen
in an old comment there.  Also make intorel_receive use ExecMaterializeSlot
not ExecCopySlotTuple, for consistency with ExecInsert and to possibly save
a tuple copy step in some cases.

Modified Files:
--------------
    pgsql/src/backend/executor:
        execAmi.c (r1.95 -> r1.96)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/executor/execAmi.c?r1=1.95&r2=1.96)
        execMain.c (r1.310 -> r1.311)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/executor/execMain.c?r1=1.310&r2=1.311)
        execUtils.c (r1.155 -> r1.156)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/executor/execUtils.c?r1=1.155&r2=1.156)
    pgsql/src/include/executor:
        executor.h (r1.148 -> r1.149)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/include/executor/executor.h?r1=1.148&r2=1.149)
    pgsql/src/include/nodes:
        execnodes.h (r1.184 -> r1.185)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/include/nodes/execnodes.h?r1=1.184&r2=1.185)

pgsql-committers by date

Next:From: User PgunittestDate: 2008-07-26 20:10:03
Subject: pgscript - pgScript: Makefile and configure reorganization
Previous:From: User PgunittestDate: 2008-07-26 18:26:17
Subject: pgscript - pgScript: Script updates

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group