Re: PATCH: CITEXT 2.0

From: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
To: "David E(dot) Wheeler" <david(at)kineticode(dot)com>
Cc: Teodor Sigaev <teodor(at)sigaev(dot)ru>, Zdenek Kotala <Zdenek(dot)Kotala(at)Sun(dot)COM>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: PATCH: CITEXT 2.0
Date: 2008-07-03 16:53:15
Message-ID: 20080703165315.GB18252@alvh.no-ip.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

David E. Wheeler wrote:
> On Jul 3, 2008, at 00:19, Teodor Sigaev wrote:
>
>>> Hash opclass is 5-times simpler that btree one :)
>>
>> CREATE FUNCTION citext_hash(mchar)
>> RETURNS int4
>> AS 'MODULE_PATHNAME'
>> LANGUAGE C IMMUTABLE RETURNS NULL ON NULL INPUT;
>>
>> CREATE OPERATOR CLASS citext_ops
>> DEFAULT FOR TYPE mchar USING hash AS
>> OPERATOR 1 = (citext, citext),
>> FUNCTION 1 citext_hash(citext);
>
> Thanks. What would citext_hash() look like? I don't see a text_hash() to
> borrow from anywhere in src/.

See hash_any(). I assume the difficulty is making sure that
hash("FOO") = hash("foo") ...

--
Alvaro Herrera http://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Dean Rasheed 2008-07-03 16:58:07 Re: Auto-explain patch
Previous Message Tom Lane 2008-07-03 16:07:41 Re: A Windows x64 port of PostgreSQL