Re: Fix pg_ctl restart bug

From: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: Fix pg_ctl restart bug
Date: 2008-06-26 15:04:34
Message-ID: 20080626150434.GA4396@alvh.no-ip.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Bruce Momjian wrote:
> Tom Lane wrote:
> > Bruce Momjian <bruce(at)momjian(dot)us> writes:
> > > However, as of 2004-10-15, this has not worked. :-( The attached patch
> > > is the one that caused the bug --- on non-Unix systems, SYSTEMQUOTE is
> > > "", meaning zero-length string. I should have seen the bug when I
> > > applied the contributed patch in 2004.
> >
> > So, shouldn't this fix be back-patched?
>
> Well, no one has actually complained about the breakage, and it has been
> a few years. Also there is always the risk of a new bug being
> introduced, so I am unsure.

Why do we need someone to complain? We know the bug is there. Has the
code changed a lot in that area?

--
Alvaro Herrera http://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Alvaro Herrera 2008-06-26 15:14:58 Re: get_relation_stats_hook()
Previous Message Pavel Stehule 2008-06-26 15:03:19 Re: variadic function support