Skip site navigation (1) Skip section navigation (2)

Re: Simplify formatting.c

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Euler Taveira de Oliveira <euler(at)timbira(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: Simplify formatting.c
Date: 2008-06-23 19:30:19
Message-ID: 200806231930.m5NJUJm07912@momjian.us (view raw or flat)
Thread:
Lists: pgsql-patches
Euler Taveira de Oliveira wrote:
> Tom Lane wrote:
> 
> > Also, it seems a bit inconsistent to be relying on
> > oracle_compat.c for upper/lower but not initcap.
> > 
> I saw this inconsistence while I'm doing the patch. What about moving 
> that upper/lower/initcap and wcs* code to another file. pg_locale.c? 
> BTW, formatting.c and oracle_compat.c already include pg_locale.h.

I researched this idea but is seems pg_locale.c contains only
locale-specific stuff, while these functions have locale and non-locale
versions;  I ended up moving the common stuff into formatting.c.

-- 
  Bruce Momjian  <bruce(at)momjian(dot)us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

  + If your life is a hard drive, Christ can be your backup. +

In response to

pgsql-patches by date

Next:From: Bruce MomjianDate: 2008-06-23 21:35:43
Subject: Re: Database owner installable modules patch
Previous:From: Bruce MomjianDate: 2008-06-23 19:28:29
Subject: Re: Simplify formatting.c

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group