doc patch - archive/restore_command on windows

From: ITAGAKI Takahiro <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp>
To: pgsql-patches(at)postgresql(dot)org
Subject: doc patch - archive/restore_command on windows
Date: 2008-06-20 07:50:07
Message-ID: 20080620163836.7629.52131E4D@oss.ntt.co.jp
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

I found the examples of documentation about archive_command and
restore_command for Windows are incorrect or improper.

- "copy" doesn't accept / (slash) as a path separator.
We should use \\ (double backslash) for the purpose.
- Windows path is typically starts with a drive letter (C:\\).
- We'd better to quote a whole path, not only the last filename
with double-quotes. It can work, but is not a windows manner.

Index: doc/src/sgml/backup.sgml
===================================================================
--- doc/src/sgml/backup.sgml (HEAD)
+++ doc/src/sgml/backup.sgml (working copy)
@@ -1122,7 +1122,7 @@
when so asked. Examples:
<programlisting>
restore_command = 'cp /mnt/server/archivedir/%f "%p"'
-restore_command = 'copy /mnt/server/archivedir/%f "%p"' # Windows
+restore_command = 'copy "C:\\server\\archivedir/%f" "%p"' # Windows
</programlisting>
</para>
</listitem>
Index: doc/src/sgml/config.sgml
===================================================================
--- doc/src/sgml/config.sgml (HEAD)
+++ doc/src/sgml/config.sgml (working copy)
@@ -1698,7 +1698,7 @@
and only if it succeeds. Examples:
<programlisting>
archive_command = 'cp "%p" /mnt/server/archivedir/"%f"'
-archive_command = 'copy "%p" /mnt/server/archivedir/"%f"' # Windows
+archive_command = 'copy "%p" "C:\\server\\archivedir\\%f"' # Windows
</programlisting>
</para>
</listitem>

Regards,
---
ITAGAKI Takahiro
NTT Open Source Software Center

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message ITAGAKI Takahiro 2008-06-20 07:52:25 Re: doc patch - archive/restore_command on windows
Previous Message Hans-Juergen Schoenig 2008-06-20 05:49:17 Re: posix advises ...