Skip site navigation (1) Skip section navigation (2)

Re: GIN improvements

From: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
To: Teodor Sigaev <teodor(at)sigaev(dot)ru>
Cc: Patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: GIN improvements
Date: 2008-06-08 22:46:49
Message-ID: 20080608224649.GC11028@alvh.no-ip.org (view raw or flat)
Thread:
Lists: pgsql-hackerspgsql-patches
Teodor Sigaev wrote:
>
>> 2) fast insert into GIN
> New version:
> http://www.sigaev.ru/misc/fast_insert_gin-0.6.gz
>
> Changes:
> - added option FASTUPDATE=(1|t|true|on|enable|0|f|false|disable) for
>   CREATE/ALTER command for GIN indexes
> - Since there wasn't any comments on first email, pg_am.aminsertcleanup optional
>   method was introduced.

Hmm, this alters the semantics of amvacuumcleanup a bit.  Currently in
btvacuumcleanup we invoke btvacuumscan only if btbulkdelete was not
called.  This is noticed by observing whether the "stats" pointer is
NULL.  However, the patch changes this a bit because
index_vacuum_cleanup is called with the results of index_insert_cleanup,
instead of a plain NULL.

Right now this is not a problem because there is no insert_cleanup
function for btree, but I wonder if we should clean it up.

FWIW there's a typo in catalogs.sgml (finction -> function)


What's the use of the FASTUPDATE parameter?  Is there a case when a user
is interested in turning it off?

-- 
Alvaro Herrera                                http://www.CommandPrompt.com/
The PostgreSQL Company - Command Prompt, Inc.

In response to

Responses

pgsql-hackers by date

Next:From: Tom LaneDate: 2008-06-08 23:03:13
Subject: Re: Proposal - improve eqsel estimates by including histogram bucket numdistinct statistics
Previous:From: Alvaro HerreraDate: 2008-06-08 22:26:26
Subject: Re: GIN improvements

pgsql-patches by date

Next:From: Neil ConwayDate: 2008-06-09 07:25:13
Subject: Minor pedantry for "help" text
Previous:From: Alvaro HerreraDate: 2008-06-08 22:26:26
Subject: Re: GIN improvements

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group