Skip site navigation (1) Skip section navigation (2)

Re: [HACKERS] use of pager on Windows psql

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: [HACKERS] use of pager on Windows psql
Date: 2008-05-17 23:36:06
Message-ID: 200805172336.m4HNa7G22034@momjian.us (view raw or flat)
Thread:
Lists: pgsql-hackerspgsql-patches
Andrew Dunstan wrote:
> > Not sure why ware are not.  Should we enabled that code on Win32 and see
> > how it works?  Can you test it? Was it some MinGW limitation?  I do see
> > isatty() being used on lots of platforms.
> >
> > This is kind of odd.  Ah, I bet it came from libpq's PQprint(), which I
> > think we had working on Win32 long before we had psql working and
> > perhaps I copied it from there.  I don't see the Win32 checks around
> > isatty() anywhere else.
> >
> >   
> >> In fact, it looks to me like it would be much more sensible to #include 
> >> "settings.h" and then simply test pset.notty for all platforms.
> >>     
> >
> > Yes, we could do that but does the isatty() value ever change while psql
> > is running?  When you do '\g filename' does stdout then have isatty as
> > false?
> >   
> 
> 
> Good point. I think the best thing would just be to remove the #ifndef 
> WIN32 / #endif lines

OK, patch applied to remove the Win32 test in both places.

I was wrong about \g filename changing stdout, I think.  It keeps stdout
but uses a different output stream.  I am just unsure, given all the
features of psql, wether it could change stdin/stdout while running in
some way.

-- 
  Bruce Momjian  <bruce(at)momjian(dot)us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

  + If your life is a hard drive, Christ can be your backup. +

Attachment: /rtmp/diff
Description: text/x-diff (1.7 KB)

In response to

Responses

pgsql-hackers by date

Next:From: Andrew DunstanDate: 2008-05-17 23:44:48
Subject: Re: windows builds hanging on regression checks
Previous:From: Tom LaneDate: 2008-05-17 23:23:20
Subject: Re: windows builds hanging on regression checks

pgsql-patches by date

Next:From: davegDate: 2008-05-17 23:38:18
Subject: Re: pg_dump lock timeout - resend
Previous:From: Tom LaneDate: 2008-05-17 22:52:54
Subject: Re: psql command aliases support

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group