Skip site navigation (1) Skip section navigation (2)

Re: Patch to change psql default banner v6

From: David Fetter <david(at)fetter(dot)org>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Bruce Momjian <bruce(at)momjian(dot)us>,Alvaro Herrera <alvherre(at)commandprompt(dot)com>,"Joshua D(dot) Drake" <jd(at)commandprompt(dot)com>,pgsql-patches(at)postgresql(dot)org
Subject: Re: Patch to change psql default banner v6
Date: 2008-05-16 05:38:38
Message-ID: 20080516053838.GA22821@fetter.org (view raw or flat)
Thread:
Lists: pgsql-patches
On Fri, May 16, 2008 at 01:22:55AM -0400, Tom Lane wrote:
> David Fetter <david(at)fetter(dot)org> writes:
> > I believe there's a bug in this patch, namely that the warnings when
> > there's a server-client mismatch only appear at startup time.
> 
> Please do not blame this patch for a problem that has been there all
> along.
> 
> I don't say that the point doesn't need investigation, but blaming
> the patch-at-hand for the issue is just misleading.

The patch at hand, as you point out, emphasizes a problem that's been
there all along, namely that \c doesn't do the same things that
command line connection does.

I'm volunteering to make them use the same methods :)

Cheers,
David.
-- 
David Fetter <david(at)fetter(dot)org> http://fetter.org/
Phone: +1 415 235 3778  AIM: dfetter666  Yahoo!: dfetter
Skype: davidfetter      XMPP: david(dot)fetter(at)gmail(dot)com

Remember to vote!
Consider donating to Postgres: http://www.postgresql.org/about/donate

In response to

Responses

pgsql-patches by date

Next:From: Merlin MoncureDate: 2008-05-16 13:28:49
Subject: Re: libpq object hooks
Previous:From: Tom LaneDate: 2008-05-16 05:22:55
Subject: Re: Patch to change psql default banner v6

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group