Skip site navigation (1) Skip section navigation (2)

Re: pg_postmaster_reload_time() patch

From: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
To: George Gensure <werkt0(at)gmail(dot)com>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: pg_postmaster_reload_time() patch
Date: 2008-04-30 12:16:11
Message-ID: 20080430121610.GA5622@alvh.no-ip.org (view raw or flat)
Thread:
Lists: pgsql-patches
George Gensure escribió:
> I've done a quick write up for reload time reporting from the
> administration TODO.  I was a little paranoid with the locking, but
> didn't want problems to occur with signals on the postmaster and the
> read side.

I'd say too much -- postmaster runs with signals blocked all the time
(except during select()) so this is not necessary there.

Regarding the locking on backends, I admit I am not sure if this is
really a problem enough that you need a spinlock for it.  Anyway we tend
not to use spinlocks too much -- probably an LWLock would be more
apropos, if a lock is really needed.  (A bigger question is whether the
reload time should be local for each backend, or exposed globally
through MyProc.  I don't think it's interesting enough to warrant that,
but perhaps others think differently.)

Lastly, I didn't read the patch close enough to tell if it would work on
both the EXEC_BACKEND case and the regular one.

-- 
Alvaro Herrera                                http://www.CommandPrompt.com/
The PostgreSQL Company - Command Prompt, Inc.

In response to

Responses

pgsql-patches by date

Next:From: Alvaro HerreraDate: 2008-04-30 12:39:01
Subject: Re: Documentation: ALTER ROLE - no password
Previous:From: Simon RiggsDate: 2008-04-30 11:49:44
Subject: Re: Patch to add a feature to pg_standby

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group