Skip site navigation (1) Skip section navigation (2)

Re: [HACKERS] Removing typename from A_Const (was: Emptyarrays with ARRAY[])

From: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Brendan Jurd <direvus(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org, pgsql-patches(at)postgresql(dot)org
Subject: Re: [HACKERS] Removing typename from A_Const (was: Emptyarrays with ARRAY[])
Date: 2008-04-28 20:25:03
Message-ID: 20080428202503.GF5761@alvh.no-ip.org (view raw or flat)
Thread:
Lists: pgsql-hackerspgsql-patches
Tom Lane escribió:
> Alvaro Herrera <alvherre(at)commandprompt(dot)com> writes:
> > Tom Lane escribió:
> >> They're logically different things, and after I get done putting a parse
> >> location field into A_Const, they'll still be physically different too.
> 
> > Aha.  Are you working from Brendan's patch?  I was going to commit it.
> 
> Sure, go ahead.  I was going to add the parse location at the same time,
> but it can perfectly well be done as a separate patch.

I came up with the attached patch.  I added the location bits (although
I am unsure if I got the locations right in the parser), but they are
unused -- figuring out how to use them would take me longer than I can
to spend on this.

-- 
Alvaro Herrera                                http://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support

Attachment: aconst-no-typename-1.patch
Description: text/x-diff (41.0 KB)

In response to

Responses

pgsql-hackers by date

Next:From: Joshua D. DrakeDate: 2008-04-28 20:47:16
Subject: WANTED: VACUUM SUMMARY
Previous:From: Stephen FrostDate: 2008-04-28 19:17:35
Subject: Re: Protection from SQL injection

pgsql-patches by date

Next:From: Alvaro HerreraDate: 2008-04-28 20:55:15
Subject: Re: [HACKERS] Removing typename from A_Const (was: Emptyarrays with ARRAY[])
Previous:From: Tom LaneDate: 2008-04-28 17:05:38
Subject: Re: [HACKERS] Removing typename from A_Const (was: Empty arrays with ARRAY[])

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group