Skip site navigation (1) Skip section navigation (2)

Re: Removing typename from A_Const (was: Empty arrayswith ARRAY[])

From: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
To: Brendan Jurd <direvus(at)gmail(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)postgresql(dot)org, pgsql-patches(at)postgresql(dot)org
Subject: Re: Removing typename from A_Const (was: Empty arrayswith ARRAY[])
Date: 2008-04-28 16:27:02
Message-ID: 20080428162702.GC5761@alvh.no-ip.org (view raw or flat)
Thread:
Lists: pgsql-hackerspgsql-patches
Brendan Jurd escribió:

> Here's my attempt to remove the typename field from A_Const.  There
> were a few places (notably flatten_set_variable_args() in guc.c, and
> typenameTypeMod() in parse_type.c) where the code expected to see an
> A_Const with a typename, and I had to adjust for an A_Const within a
> TypeCast.  Nonetheless, there was an overall net reduction of 34 lines
> of code, so I think this was a win.

Do say ... why don't we do away with A_Const altogether and just replace
it with Value?  After this patch, I don't see what's the difference.

-- 
Alvaro Herrera                                http://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support

In response to

Responses

pgsql-hackers by date

Next:From: Tom LaneDate: 2008-04-28 16:50:18
Subject: Re: Removing typename from A_Const (was: Empty arrays with ARRAY[])
Previous:From: Chris BrowneDate: 2008-04-28 15:55:18
Subject: Re: we don't have a bugzilla

pgsql-patches by date

Next:From: Tom LaneDate: 2008-04-28 16:50:18
Subject: Re: Removing typename from A_Const (was: Empty arrays with ARRAY[])
Previous:From: Alvaro HerreraDate: 2008-04-28 14:52:33
Subject: Re: generate_subscripts

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group