Re: Re: [HACKERS] [COMMITTERS] pgsql: Fix TransactionIdIsCurrentTransactionId() to use binary search

From: Robert Treat <xzilla(at)users(dot)sourceforge(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-performance(at)postgresql(dot)org, Alvaro Herrera <alvherre(at)commandprompt(dot)com>
Subject: Re: Re: [HACKERS] [COMMITTERS] pgsql: Fix TransactionIdIsCurrentTransactionId() to use binary search
Date: 2008-04-26 18:20:15
Message-ID: 200804261420.16064.xzilla@users.sourceforge.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers pgsql-performance

On Saturday 26 April 2008 13:26, Tom Lane wrote:
> Robert Treat <xzilla(at)users(dot)sourceforge(dot)net> writes:
> > On Friday 25 April 2008 17:32, Tom Lane wrote:
> >> Robert Treat <xzilla(at)users(dot)sourceforge(dot)net> writes:
> >>> Oddly some dtrace profiling gave me this, which is pretty different,
> >>> but certainly doesn't have concerns about
> >>> TransactionIdIsCurrentTransactionId
> >>
> >> .... which seems to pretty much destroy your thesis, no?
> >
> > How so? Before the patch we bog down for hours, spending 99% of our time
> > in TransactionIdIsCurrentTransactionId, after the patch everything
> > performs well (really better than before) and we spend so little time in
> > TransactionIdIsCurrentTransactionId it barely shows up on the radar.
>
> Oh, you failed to state that the dtrace output was post-patch. You need
> to show *pre* patch dtrace output if you want us to think it relevant.
>

Please read up-thread.

--
Robert Treat
Build A Brighter LAMP :: Linux Apache {middleware} PostgreSQL

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2008-04-26 22:47:40 pgsql: Code review for recent patch to terminate online backup during
Previous Message Tom Lane 2008-04-26 17:33:01 Re: Re: [COMMITTERS] pgsql: Update: < * Allow adding enumerated values to an existing

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2008-04-26 23:20:29 Re: Re: [HACKERS] [COMMITTERS] pgsql: Fix TransactionIdIsCurrentTransactionId() to use binary search
Previous Message Joshua D. Drake 2008-04-26 17:37:34 Re: we don't have a bugzilla

Browse pgsql-performance by date

  From Date Subject
Next Message Craig Ringer 2008-04-26 18:51:55 Re: Best practice to load a huge table from ORACLE to PG
Previous Message Tom Lane 2008-04-26 17:26:44 Re: Re: [HACKERS] [COMMITTERS] pgsql: Fix TransactionIdIsCurrentTransactionId() to use binary search