Skip site navigation (1) Skip section navigation (2)

pgsql: Fix ALTER TABLE ADD COLUMN ...

From: tgl(at)postgresql(dot)org (Tom Lane)
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Fix ALTER TABLE ADD COLUMN ...
Date: 2008-04-24 20:17:50
Message-ID: 20080424201750.877377559CC@cvs.postgresql.org (view raw or flat)
Thread:
Lists: pgsql-committers
Log Message:
-----------
Fix ALTER TABLE ADD COLUMN ... PRIMARY KEY so that the new column is correctly
checked to see if it's been initialized to all non-nulls.  The implicit NOT
NULL constraint was not being checked during the ALTER (in fact, not even if
there was an explicit NOT NULL too), because ATExecAddColumn neglected to
set the flag needed to make the test happen.  This has been broken since
the capability was first added, in 8.0.

Brendan Jurd, per a report from Kaloyan Iliev.

Modified Files:
--------------
    pgsql/src/backend/commands:
        tablecmds.c (r1.250 -> r1.251)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/commands/tablecmds.c?r1=1.250&r2=1.251)
    pgsql/src/test/regress/expected:
        alter_table.out (r1.104 -> r1.105)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/test/regress/expected/alter_table.out?r1=1.104&r2=1.105)
    pgsql/src/test/regress/sql:
        alter_table.sql (r1.56 -> r1.57)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/test/regress/sql/alter_table.sql?r1=1.56&r2=1.57)

pgsql-committers by date

Next:From: Tom LaneDate: 2008-04-24 20:17:59
Subject: pgsql: Fix ALTER TABLE ADD COLUMN ...
Previous:From: Bruce MomjianDate: 2008-04-24 19:58:32
Subject: pgsql: Add embedded usage mention to FAQ, per Greg Smith.

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group