Skip site navigation (1) Skip section navigation (2)

Re: Improve shutdown during online backup, take 4

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: "Albe Laurenz" <laurenz(dot)albe(at)wien(dot)gv(dot)at>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: Improve shutdown during online backup, take 4
Date: 2008-04-23 08:43:23
Message-ID: 20080423104323.04948d8f@mha-laptop (view raw or flat)
Thread:
Lists: pgsql-patches
Albe Laurenz wrote:
> Magnus Hagander wrote:
> > This doesn't look like our normal coding standards, and should
> > probably be changed:
> > + 	if (0 != stat(BACKUP_LABEL_FILE, &stat_buf))
> > 
> > (there's a number of similar places)
> 
> I see. Lacking guidelines, I now copied how stat(2) is used in
> other parts of the code.

Really? I thought we didn't do that :), and I recall having my own
patches bounced for the same reason.

Just to be sure, we are talking about the
if (0 == foo)
vs
if (foo == 0)

thing, right? If not, then I wasn't clear enough in my note :-(

//Magnus

In response to

pgsql-patches by date

Next:From: H.HaradaDate: 2008-04-23 10:45:32
Subject: temporal version of generate_series()
Previous:From: Albe LaurenzDate: 2008-04-23 08:40:29
Subject: Re: Improve shutdown during online backup, take 3

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group