| From: | Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
|---|---|
| To: | Simon Riggs <simon(at)2ndquadrant(dot)com> |
| Cc: | Pg Patches <pgsql-patches(at)postgresql(dot)org> |
| Subject: | Re: Snapshot management, final |
| Date: | 2008-04-22 21:50:56 |
| Message-ID: | 20080422215056.GJ6912@alvh.no-ip.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-patches |
Simon Riggs wrote:
> On Tue, 2008-04-22 at 15:49 -0400, Alvaro Herrera wrote:
>
> > - Three CopySnapshot call sites remain outside snapmgr.c: DoCopy() on
> > copy.c, ExplainOnePlan() on explain.c and _SPI_execute_plan() on spi.c.
> > They are there because they grab the current ActiveSnapshot, modify it,
> > and then use the resulting snapshot. There is no corresponding
> > FreeSnapshot, because it's not needed.
>
> Not needed? How can we be certain that the modified snapshot does not
> outlive its original source?
It's not CopySnapshot that's not needed, but FreeSnapshot. The point
here is that the snapshot will be freed automatically as soon as it is
PopActiveSnapshot'd out of existance. CopySnapshot creates a new,
separate copy of the passed snapshot, and each of them will be freed
(separately) as soon as their refcounts reach zero.
--
Alvaro Herrera http://www.CommandPrompt.com/
The PostgreSQL Company - Command Prompt, Inc.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Simon Riggs | 2008-04-22 21:58:38 | Re: Snapshot management, final |
| Previous Message | Simon Riggs | 2008-04-22 21:45:12 | Re: Snapshot management, final |