From: | Magnus Hagander <magnus(at)hagander(dot)net> |
---|---|
To: | Magnus Hagander <magnus(at)hagander(dot)net> |
Cc: | Andrew Dunstan <andrew(at)dunslane(dot)net>, Tom Lane <tgl(at)postgresql(dot)org>, pgsql-committers(at)postgresql(dot)org |
Subject: | Re: pgsql: Add FLOAT4PASSBYVAL/FLOAT8PASSBYVAL to pg_config.h.win32, as a |
Date: | 2008-04-21 10:02:29 |
Message-ID: | 20080421120229.09a6e9a6@mha-laptop |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Magnus Hagander wrote:
> Andrew Dunstan wrote:
> >
> >
> > Tom Lane wrote:
> > > Log Message:
> > > -----------
> > > Add FLOAT4PASSBYVAL/FLOAT8PASSBYVAL to pg_config.h.win32, as a
> > > stopgap measure to get the Windows buildfarm members working
> > > again. I don't know if it's worth exposing these as
> > > configurables, or exactly how to do it in the MSVC build
> > > system ...
> > >
> > >
> > >
> >
> > see src/tools/msvc/Solution.pm
> >
> > The options are picked up from config.pl (which is the equivalent
> > of configure invocation options) in the new() subroutine, and the
> > config files are written accordingly in the GenerateFiles()
> > subroutine.
> >
> > In general I'm in favor of keeping these as closely aligned as
> > possible.
>
> Agreed. If it's a configurable option in the autoconf system, it
> should be in the msvc one. I'll see if I can get this done during the
> day today before you guys wake up again ;-)
Done.
//Magnus
From | Date | Subject | |
---|---|---|---|
Next Message | Magnus Hagander | 2008-04-21 11:06:13 | pgsql: Fix typo, noted by Stefan Kaltenbrunner. |
Previous Message | Magnus Hagander | 2008-04-21 10:01:32 | pgsql: Make float4byval and float8byval configurable on MSVC. |