Skip site navigation (1) Skip section navigation (2)

Re: float4/float8/int64 passed by value with tsearchfixup

From: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
To: Zoltan Boszormenyi <zb(at)cybertec(dot)at>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Gregory Stark <stark(at)enterprisedb(dot)com>, pgsql-patches(at)postgresql(dot)org, Hans-Juergen Schoenig <hs(at)cybertec(dot)at>, Magnus Hagander <magnus(at)hagander(dot)net>
Subject: Re: float4/float8/int64 passed by value with tsearchfixup
Date: 2008-04-18 18:46:25
Message-ID: 20080418184625.GA572@alvh.no-ip.org (view raw or flat)
Thread:
Lists: pgsql-patches
Zoltan Boszormenyi wrote:

> - float4 conversion is risk free (patch #1)

I applied this #1 patch.  It needed some further adjustments; in
particular contrib/btree_gist regression check was crashing, and
utils/fmgr/README needed updating.

With contrib/seg also adjusted to use float4 instead of float32, and
thus the last usage of float32 gone, I am now wondering if it would be a
good idea to remove the float32 and float32data definitions in c.h.

Thanks to Zoltan for the patch.

-- 
Alvaro Herrera                                http://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support

In response to

Responses

pgsql-patches by date

Next:From: Alvaro HerreraDate: 2008-04-18 19:10:08
Subject: Re: float4/float8/int64 passed by value with tsearchfixup
Previous:From: Bryce NesbittDate: 2008-04-18 18:46:12
Subject: Re: [PATCHES] Coding standards

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group