From: | Martijn van Oosterhout <kleptog(at)svana(dot)org> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Heikki Linnakangas <heikki(at)enterprisedb(dot)com>, Alvaro Herrera <alvherre(at)commandprompt(dot)com>, pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: Re: [COMMITTERS] pgsql: Repair two places where SIGTERM exit couldleave shared memory |
Date: | 2008-04-18 07:09:27 |
Message-ID: | 20080418070927.GC2482@svana.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers pgsql-hackers |
On Thu, Apr 17, 2008 at 11:48:41AM -0400, Tom Lane wrote:
> Martijn van Oosterhout <kleptog(at)svana(dot)org> writes:
> > Is this so? This happened to me the other day (hence the question about
> > having COPY note failure earlier) because the disk filled up. I was
> > confused because du showed nothing. Eventually I did an lsof and found
> > the postgres backend had a large number of open file handles to deleted
> > files (each one gigabyte).
>
> The backend, or the bgwriter? Please be specific.
I beleive the backend, because I was using lsof -p <pid> using the pid
copied from ps. But I can't be 100%.
> 8.3 and HEAD should ftruncate() the first segment of a relation but I
> think they just unlink the rest. Is it sane to think of ftruncate then
> unlink on the non-first segments, to alleviate the disk-space issue when
> someone else is holding the file open?
It's possible. OTOH, if the copy error had been return in the
PQputline() the driving program (which has several COPYs running at
once) would have aborted and the data would have been reclaimed
immediately. As it is it kept going for an hour before noticing and
then dying (and cleaning everything up).
The one ftruncate does explain why there was some free space, so that
part is appreciated.
Have a nice day,
--
Martijn van Oosterhout <kleptog(at)svana(dot)org> http://svana.org/kleptog/
> Please line up in a tree and maintain the heap invariant while
> boarding. Thank you for flying nlogn airlines.
From | Date | Subject | |
---|---|---|---|
Next Message | User Gleu | 2008-04-18 09:36:44 | pgsnap - pgsnap: Add an explanation for the install process, from Damien |
Previous Message | Heikki Linnakangas | 2008-04-18 06:48:51 | pgsql: Fix two race conditions between the pending unlink mechanism that |
From | Date | Subject | |
---|---|---|---|
Next Message | Bryce Nesbitt | 2008-04-18 07:11:58 | Re: Proposed patch - psql wraps at window width |
Previous Message | Bryce Nesbitt | 2008-04-18 07:07:29 | Re: Proposed patch - psql wraps at window width |