Skip site navigation (1) Skip section navigation (2)

Re: Proposed patch - psql wraps at window width

From: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
To: Bryce Nesbitt <bryce2(at)obviously(dot)com>
Cc: pgsql-patches(at)postgresql(dot)org, Bruce Momjian <bruce(at)momjian(dot)us>, heikki(at)enterprisedb(dot)com
Subject: Re: Proposed patch - psql wraps at window width
Date: 2008-04-17 20:53:08
Message-ID: 20080417205307.GT3846@alvh.no-ip.org (view raw or flat)
Thread:
Lists: pgsql-hackerspgsql-patches
Bryce Nesbitt wrote:
> I've attached a patch, against current 8.4 cvs, which optionally sets a  
> maximum width for psql output:

Some random comments:

* Don't use C++ style comments (//).  Some compilers don't like these.

* Beware of brace position: we use braces on their own, indented at the
  start of a new line, so

! 	while(--count) {
!         lines++;                
! 		lines->ptr   = NULL;
! 		lines->width = 0;
!         }

becomes


! 	while(--count)
!       {
!         lines++;                
! 		lines->ptr   = NULL;
! 		lines->width = 0;
!         }

(with correct indentation anyway)


* Always use tabs, not spaces, to indent.  Tabs are 4 spaces wide.

* Don't use double stars in comments.

* We're not in the habit of giving credit in code comments.  It gets
messy fast.

* Don't lose warning comments like this one (unless you've removed the
assumption of course)

/*
 * Assumption: This code used only on strings
 * without multibyte characters, otherwise
 * this_line->width < strlen(this_ptr) and we get
 * an overflow
 */

In fact I wonder if you've introduced this assumption in the other case
on that code (i.e. when alignment is not 'r').  I'm not seeing any
checks for multibytes in there, but perhaps I'm missing it.


* "} else" is forbidden too.  Use two separate lines.

-- 
Alvaro Herrera                                http://www.CommandPrompt.com/
The PostgreSQL Company - Command Prompt, Inc.

In response to

Responses

pgsql-hackers by date

Next:From: Bruce MomjianDate: 2008-04-17 20:55:12
Subject: Re: Proposed patch - psql wraps at window width
Previous:From: Stephen DenneDate: 2008-04-17 20:43:13
Subject: Re: count(*) performance improvement ideas

pgsql-patches by date

Next:From: Bruce MomjianDate: 2008-04-17 20:55:12
Subject: Re: Proposed patch - psql wraps at window width
Previous:From: Heikki LinnakangasDate: 2008-04-17 19:48:27
Subject: Re: Patch for Prevent pg_dump/pg_restore from being affected by statement_timeout

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group