Re: [PATCHES] Avahi support for Postgresql

From: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: Mathias Hasselmann <mathias(at)openismus(dot)com>, Peter Eisentraut <peter_e(at)gmx(dot)net>, pgsql-hackers(at)postgresql(dot)org, Murray Cumming <murrayc(at)openismus(dot)com>
Subject: Re: [PATCHES] Avahi support for Postgresql
Date: 2008-04-15 15:06:23
Message-ID: 20080415150622.GD4429@alvh.no-ip.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Bruce Momjian wrote:
> Alvaro Herrera wrote:
> > Mathias Hasselmann wrote:
> >
> > > The patches were in my initial mail, but now I've also uploaded them to
> > > my personal site for convenience:
> > >
> > > http://taschenorakel.de/files/pgsql-avahi-support/
> >
> > Hmm, a quick look at the third patch reveals that it is using the
> > "threaded" Avahi client. That's a showstopper. Please consider using
> > some other approach -- writing our own handlers for AvahiPoll would seem
> > apropos.
>
> Based on the threading usage in this patch, I assume it is rejected, and
> that we don't want a TODO item for this.

This particular patch should be rejected, but we certainly do need a
TODO item IMHO.

--
Alvaro Herrera http://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2008-04-15 15:09:10 Re: Idle idea for improving concurrency of LISTEN/NOTIFY
Previous Message Merlin Moncure 2008-04-15 14:57:37 Re: pulling libpqtypes from queue

Browse pgsql-patches by date

  From Date Subject
Next Message Andrew Dunstan 2008-04-15 16:29:51 Re: [HACKERS] MSVC build broken with perl 5.10
Previous Message Bruce Momjian 2008-04-15 15:02:13 Re: lc_time and localized dates