Skip site navigation (1) Skip section navigation (2)

Re: libpq Win32 Mutex performance patch

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: Andrew Chernow <ac(at)esilo(dot)com>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: libpq Win32 Mutex performance patch
Date: 2008-04-15 08:00:06
Message-ID: 20080415100006.62eb0166@mha-laptop (view raw or flat)
Thread:
Lists: pgsql-patches
Andrew Chernow wrote:
> Magnus Hagander wrote:
> 
>  >It changes the behavior when the pointer passed in is invalid from
>  >crash to silent working, right?
> 
> Correct, it a Habit.  I sub-consciously write code that checks
> pointers. We can remove the pointer checks and let the thing dump
> core if people prefer.

Actually, if we can avoid it being a pointer at all, that'd be even
better :-) Because if we don't send a pointer we have to allocate, then
the critical section functions have the same properties as the pthread
ones, namely they cannot fail. Any chance for that way instead?

//Magnus

In response to

pgsql-patches by date

Next:From: Magnus HaganderDate: 2008-04-15 08:07:55
Subject: Re: libpq Win32 Mutex performance patch
Previous:From: Alvaro HerreraDate: 2008-04-14 23:57:53
Subject: Re: explicit tracking of ActiveSnapshot

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group