Re: Fix for win32 stat() problems

From: Magnus Hagander <magnus(at)hagander(dot)net>
To:
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: Fix for win32 stat() problems
Date: 2008-04-10 17:00:10
Message-ID: 20080410190010.7a0fc21a@mha-laptop
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Magnus Hagander wrote:
> Magnus Hagander wrote:
> > Attached is a patch that attempts to fix the issues with stat() not
> > properly updating st_size on win32, as reported in this thread:
> > http://archives.postgresql.org/pgsql-hackers/2008-03/msg01181.php
> >
> > It has to have a chance to affect things beyond just the
> > pg_relation_size() function, so this patch fixes all cases where we
> > do stat() and use the st_size member. It doesn't change all
> > occurances of stat() since I didn't want to incur the double
> > filesystem lookups unnecessary cases.
> >
> > Any objections?
>
> Updated version. Seems the problem was that the includes came in the
> wrong order - figured that out just after I went to bed :) Here's an
> updated patch.
>
> A whole lot simpler patch :-)

Appled with comment adjustment, and backpatched to 8.2 and 8.3.

//Magnus

In response to

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2008-04-10 17:04:17 Re: Concurrent psql API
Previous Message Tom Lane 2008-04-10 16:58:17 Re: [PATCHES] libpq type system 0.9a