Skip site navigation (1) Skip section navigation (2)

Re: Fix for win32 stat() problems

From: Magnus Hagander <magnus(at)hagander(dot)net>
To:
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: Fix for win32 stat() problems
Date: 2008-04-10 13:23:37
Message-ID: 20080410152337.042157ca@mha-laptop (view raw or flat)
Thread:
Lists: pgsql-patches
Magnus Hagander wrote:
> Attached is a patch that attempts to fix the issues with stat() not
> properly updating st_size on win32, as reported in this thread:
> http://archives.postgresql.org/pgsql-hackers/2008-03/msg01181.php
> 
> It has to have a chance to affect things beyond just the
> pg_relation_size() function, so this patch fixes all cases where we do
> stat() and use the st_size member. It doesn't change all occurances of
> stat() since I didn't want to incur the double filesystem lookups
> unnecessary cases.
> 
> Any objections?

Updated version. Seems the problem was that the includes came in the
wrong order - figured that out just after I went to bed :) Here's an
updated patch.

A whole lot simpler patch :-)

//Magnus

Attachment: win32_stat.diff
Description: text/x-patch (1.8 KB)

In response to

Responses

pgsql-patches by date

Next:From: Gregory StarkDate: 2008-04-10 13:29:21
Subject: Re: [PATCHES] libpq type system 0.9a
Previous:From: Alvaro HerreraDate: 2008-04-10 13:08:53
Subject: Re: Fix for win32 stat() problems

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group