From: | Bruce Momjian <bruce(at)momjian(dot)us> |
---|---|
To: | Simon Riggs <simon(at)2ndquadrant(dot)com> |
Cc: | pgsql-patches(at)postgresql(dot)org, "Florian G(dot) Pflug" <fgp(at)phlo(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Subject: | Re: [HACKERS] Minor changes to Recovery related code |
Date: | 2008-04-05 01:34:58 |
Message-ID: | 200804050134.m351YwM00633@momjian.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers pgsql-patches |
Nice, applied. I only modified some of the documentation wording.
I was a little worried that statement_timeout might cancel
pg_stop_backup() _before_ it had gotten to waiting for the archive logs
to be saved, but based on what little code there is before that block, I
think we are OK.
---------------------------------------------------------------------------
Simon Riggs wrote:
> On Thu, 2008-03-27 at 17:34 +0000, Simon Riggs wrote:
> > Follow-up during March 2008 CommitFest
> >
> > On Thu, 2007-06-07 at 21:53 +0100, Simon Riggs wrote:
> > > On Sat, 2007-03-31 at 00:51 +0200, Florian G. Pflug wrote:
>
> > > - pg_stop_backup() will wait until the WAL file that ends the backup is
> > > safely archived, even if a failure to archive occurs. This is a change
> > > to current behaviour, but since it implements the originally *expected*
> > > behaviour IMHO it should be the default.
> >
> > The most straightforward thing is to make pg_stop_backup() wait as
> > described above.
> >
> > If people want it to timeout, they can use a statement_timeout as
> > suggested by Florian.
> >
> > This can be implemented by having the function poll in an infinite loop
> > for archive_status/LOG.done. Also, as Florian suggests, we should have
> > it output a WARNING message every 60 seconds.
> >
> > I'll write a patch now.
>
> Patch to implement waiting pg_stop_backup().
>
> Tested and ready to apply, includes docs.
>
> --
> Simon Riggs
> 2ndQuadrant http://www.2ndQuadrant.com
>
> PostgreSQL UK 2008 Conference: http://www.postgresql.org.uk
[ Attachment, skipping... ]
--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ If your life is a hard drive, Christ can be your backup. +
Attachment | Content-Type | Size |
---|---|---|
/rtmp/diff | text/x-diff | 7.5 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Alvaro Herrera | 2008-04-05 01:39:15 | Re: Re: [COMMITTERS] pgsql: Implement current_query(), that shows the currently executing |
Previous Message | Brendan Jurd | 2008-04-05 01:33:30 | Re: Separate psql commands from arguments |
From | Date | Subject | |
---|---|---|---|
Next Message | Andrew Chernow | 2008-04-05 02:32:35 | Re: libpq type system 0.9a |
Previous Message | Bruce Momjian | 2008-04-05 00:43:00 | Re: psql \G command -- send query and output using extended format |