Re: actualized SQL/PSM patch

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: actualized SQL/PSM patch
Date: 2008-04-03 00:44:32
Message-ID: 200804030044.m330iWu21873@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches


The author has received feedback so this has been saved for the next
commit-fest:

http://momjian.postgresql.org/cgi-bin/pgpatches_hold

---------------------------------------------------------------------------

Pavel Stehule wrote:
> Hello
>
> On 01/04/2008, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> > "Pavel Stehule" <pavel(dot)stehule(at)gmail(dot)com> writes:
> > > I actualized sql/psm patch. This patch can be downloaded from
> > > http://www.pgsql.cz/patches/plpgpsm.diff.gz
> >
> > The fundamental problem I've got with this patch is that it adds 400K
> > of new code (and that's just the code, not counting documentation or
> > regression tests) that we'll have to maintain, to obtain a feature that
> > so far as I've heard there is precisely zero demand for.
> >
> > The duplicativeness of the code with plpgsql doesn't make this prospect
> > any more pleasant, either.
> >
> > The idea would be a lot easier to swallow if the code were refactored
> > to avoid the duplication with plpgsql.
> >
>
> This is long run and needs hard reorganisation of plpgsql code. And
> moving some plpgsql code to core. But I don't expect so plpgpsm code
> can be less than 200KB.
>
> Regards
> Pavel Stehule
>
> > regards, tom lane
> >
>
> --
> Sent via pgsql-patches mailing list (pgsql-patches(at)postgresql(dot)org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgsql-patches

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +

In response to

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2008-04-03 01:56:56 Re: [8.4] Updated WITH clause patch (non-recursive)
Previous Message Bruce Momjian 2008-04-03 00:41:56 Re: printTable API (was: Show INHERIT in \du)