Re: [PATCHES] Implemented current_query

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Simon Riggs <simon(at)2ndquadrant(dot)com>
Cc: Alvaro Herrera <alvherre(at)commandprompt(dot)com>, Tomas Doran <bobtfish(at)bobtfish(dot)net>, Neil Conway <neilc(at)samurai(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgreSQL(dot)org>
Subject: Re: [PATCHES] Implemented current_query
Date: 2008-03-28 20:26:42
Message-ID: 200803282026.m2SKQg020431@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Simon Riggs wrote:
> On Fri, 2008-03-28 at 14:32 -0400, Bruce Momjian wrote:
> > Alvaro Herrera wrote:
> > > Tomas Doran wrote:
> > >
> > > > On 28 Mar 2008, at 17:23, Bruce Momjian wrote:
> > >
> > > >> Perhaps we could name it received_query() to indicate it is what the
> > > >> backend received and it not necessarily the _current_ query.
> > > >
> > > > reveived_query() sounds like a very sane name for me, and documenting it
> > > > as such would allow you to expose the functionality without the possible
> > > > complaints...
> > >
> > > client_query perhaps?
> >
> > Yea, that is consistent with what we do with other functions.
>
> How about client_request()
>
> It's then clear that a request can be made up of many statements, which
> will be executed in turn.

The problem with client_request() is that it is not clear it is a query
--- it could be a disonnection or cancel request, for example.

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2008-03-28 21:51:43 Third thoughts about the DISTINCT MAX() problem
Previous Message Tom Lane 2008-03-28 19:47:07 Re: Is psql command line interface broken on HEAD?

Browse pgsql-patches by date

  From Date Subject
Next Message Andreas 'ads' Scherbaum 2008-03-29 01:40:57 create language ... if not exists
Previous Message Brendan Jurd 2008-03-28 19:40:46 Re: [PATCHES] Text <-> C string