Skip site navigation (1) Skip section navigation (2)

Re: [COMMITTERS] pgsql: Strengthen warnings about using pg_dump's -i option.

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: [COMMITTERS] pgsql: Strengthen warnings about using pg_dump's -i option.
Date: 2008-03-26 16:45:18
Message-ID: 200803261645.m2QGjIZ10340@momjian.us (view raw or flat)
Thread:
Lists: pgsql-committerspgsql-hackers
Tom Lane wrote:
> momjian(at)postgresql(dot)org (Bruce Momjian) writes:
> > Log Message:
> > -----------
> > Strengthen warnings about using pg_dump's -i option.
> 
> The proposed TODO item was not about doing this, it was about removing
> the option altogether.  AFAICS it's a foot-gun and nothing else --- why
> do we have it?

I thought the simple fix was to just have a better warning and see how
that works in practice.  There was some concern from people about
removing it without more feedback/warning.  I am happy to remove it.

> BTW, a point I had forgotten is that pg_restore doesn't enforce that it
> not be used with a newer server:
> 
> 		/* XXX Should get this from the archive */
> 		AHX->minRemoteVersion = 070100;
> 		AHX->maxRemoteVersion = 999999;
> 
> I think this is probably sane, since after all we couldn't enforce that
> the plain script output not be loaded into a newer server.  But it means
> that -i is effectively a no-op for pg_restore, which again begs the
> question of why we have it.

So pg_restore -i does nothing?  Seems it should be removed.

The plain text file will be a foot-gun too, of course.

-- 
  Bruce Momjian  <bruce(at)momjian(dot)us>        http://momjian.us
  EnterpriseDB                             http://postgres.enterprisedb.com

  + If your life is a hard drive, Christ can be your backup. +

In response to

Responses

pgsql-hackers by date

Next:From: David FetterDate: 2008-03-26 16:54:29
Subject: Re: Surfacing qualifiers
Previous:From: Tom LaneDate: 2008-03-26 16:39:52
Subject: Re: [COMMITTERS] pgsql: Strengthen warnings about using pg_dump's -i option.

pgsql-committers by date

Next:From: Andrew DunstanDate: 2008-03-26 16:49:48
Subject: Re: pgsql: Added ECPGget_PGconn() function to ecpglib, courtesy of Mike
Previous:From: Tom LaneDate: 2008-03-26 16:39:52
Subject: Re: [COMMITTERS] pgsql: Strengthen warnings about using pg_dump's -i option.

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group