pgsql: Fix various infelicities that have snuck into usage of

Log Message:
-----------
Fix various infelicities that have snuck into usage of errdetail() and
friends. Avoid double translation of some messages, ensure other messages
are exposed for translation (and make them follow the style guidelines),
avoid unsafe passing of an unpredictable message text as a format string.

Tags:
----
REL8_3_STABLE

Modified Files:
--------------
pgsql/src/backend/catalog:
aclchk.c (r1.143 -> r1.143.2.1)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/catalog/aclchk.c?r1=1.143&r2=1.143.2.1)
pg_shdepend.c (r1.23 -> r1.23.2.1)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/catalog/pg_shdepend.c?r1=1.23&r2=1.23.2.1)
pgsql/src/backend/commands:
vacuumlazy.c (r1.103 -> r1.103.2.1)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/commands/vacuumlazy.c?r1=1.103&r2=1.103.2.1)
pgsql/src/backend/utils/adt:
xml.c (r1.68.2.1 -> r1.68.2.2)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/utils/adt/xml.c?r1=1.68.2.1&r2=1.68.2.2)