| From: | Kurt Roeckx <kurt(at)roeckx(dot)be> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: gcc 4.3 breaks ContribCheck in 8.2 and older. |
| Date: | 2008-03-24 18:47:37 |
| Message-ID: | 20080324184737.GA30480@roeckx.be |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Mar 24, 2008 at 03:05:31PM -0300, Alvaro Herrera wrote:
> Kurt Roeckx wrote:
>
> > No, this has nothing to do with CFLAGS. It's calling a function which
> > returns something other than it actually returns.
>
> Yeah but apparently gcc 4.3 is working in 8.3 and later. What happens
> to your sample program if you compile it with the CFLAGS used in 8.3
> versus those used in 8.2? pg_config --configure will show these.
8.2 and 8.3 actually get the same value in fmgr_oldstyle(), it just
seems they do something else with it somewhere else. Both are wrong,
it's just that we don't see it in 8.3.
I think it should return a Datum, and use PG_RETURN_BOOL.
Kurt
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Stefan Kaltenbrunner | 2008-03-24 18:51:17 | Re: New email list for emergency communications |
| Previous Message | Andreas 'ads' Scherbaum | 2008-03-24 18:31:16 | Re: New email list for emergency communications |