pg_dump -i wording

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Simon Riggs <simon(at)2ndquadrant(dot)com>
Cc: Alvaro Herrera <alvherre(at)commandprompt(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Neil Conway <neilc(at)samurai(dot)com>, Gregory Stark <stark(at)enterprisedb(dot)com>, "Jonah H(dot) Harris" <jonah(dot)harris(at)gmail(dot)com>, PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>
Subject: pg_dump -i wording
Date: 2008-03-23 01:10:22
Message-ID: 200803230110.m2N1AM306382@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Simon Riggs wrote:
> On Thu, 2008-01-31 at 11:20 -0300, Alvaro Herrera wrote:
> > > Tom Lane wrote:
> >
> > > > in fact, personally I'd like to make that case be a hard error,
> > > > rather than something people could override with -i.
> >
> > +1 to this idea. TODO for 8.4?
>
> -1 without some more planning about the effects and implications.

I have developed the attached patch with improves wording for the
pg_dump -i (ignore version) option.

The previous wording just said "proceed" which was very neutral. The
new wording says "skip", which is more active and more likely for people
to understand it isn't something to do lightly.

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://postgres.enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +

Attachment Content-Type Size
/pgpatches/pg_dump text/x-diff 6.5 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2008-03-23 01:14:34 Re: Building PostgreSQL 8.3.1 on OpenVMS 8.3 AXP
Previous Message Bruce Momjian 2008-03-23 00:37:06 Re: Page-at-a-time Locking Considerations

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2008-03-23 01:21:51 Re: pg_dump -i wording
Previous Message Tom Lane 2008-03-23 00:27:03 Re: [HACKERS] quote_literal with NULL