Skip site navigation (1) Skip section navigation (2)

Re: Re: [COMMITTERS] pgsql: Don't need -Wno-error anymore, because flex is no longer

From: Peter Eisentraut <peter_e(at)gmx(dot)net>
To: pgsql-hackers(at)postgresql(dot)org
Subject: Re: Re: [COMMITTERS] pgsql: Don't need -Wno-error anymore, because flex is no longer
Date: 2008-03-18 18:23:40
Message-ID: 200803181923.40492.peter_e@gmx.net (view raw or flat)
Thread:
Lists: pgsql-committerspgsql-hackers
Am Dienstag, 18. März 2008 schrieb Bruce Momjian:
> Peter Eisentraut wrote:
> > Log Message:
> > -----------
> > Don't need -Wno-error anymore, because flex is no longer producing
> > warnings.
>
> I see this patch only affects ecpg?  Is this related to Tom's report
> from trying the new flex?

Yes.  There used to be a few -Wno-error uses throughout the source code, near 
the flex calls, to work around the well-known flex warnings issue in case 
someone wanted to use -Werror to check his builds.  The fact that there was 
only one such use left in the ecpg subtree shows that this wasn't really 
maintained and could never have worked reliably.

> Are we assuming that all CVS build people 
> also have the new flex?  Is the new flex even installed on the server
> that makes our tarballs?  Are we all supposed to use the new flex?

I think it is reasonable to assume that those wanting to use -Werror should 
use the new flex, because if they don't the build will fail anyway, at any of 
the other lexers.

In response to

Responses

pgsql-hackers by date

Next:From: Bruce MomjianDate: 2008-03-18 18:41:24
Subject: Re: Proposal for Null Bitmap Optimization(for Trailing NULLs)
Previous:From: Peter EisentrautDate: 2008-03-18 18:18:31
Subject: Re: whaddya know, a build with no flex noise at all

pgsql-committers by date

Next:From: Bruce MomjianDate: 2008-03-18 18:40:42
Subject: pgsql: Add to TODO: > > * Consider not storing a NULL bitmap on disk
Previous:From: Bruce MomjianDate: 2008-03-18 17:50:32
Subject: Re: [COMMITTERS] pgsql: Don't need -Wno-error anymore, because flex is no longer

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group