Skip site navigation (1) Skip section navigation (2)

Re: Cleaner API for appendStringInfoVA

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Marko Kreen <markokr(at)gmail(dot)com>
Cc: Postgres Patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: Cleaner API for appendStringInfoVA
Date: 2008-03-07 20:22:20
Message-ID: 200803072022.m27KMKE04274@momjian.us (view raw or flat)
Thread:
Lists: pgsql-patches
Patch rejected.  Sorry.  Comment is:

The patch of very dubious portability and I'm not even convinced that
it'd provide a net performance improvement.

---------------------------------------------------------------------------

Marko Kreen wrote:
> Attached patch moves decision how much more room to allocate
> from callers of appendStringInfoVA to inside the function,
> where more info is available.
> 
> On systems with broken vsnprintf() it falls back
> to doubleing the buffer.
> 
> Fixme: the +1 could be something larger?  Aligned?
> 
> -- 
> marko

[ Attachment, skipping... ]

> 
> ---------------------------(end of broadcast)---------------------------
> TIP 3: Have you checked our extensive FAQ?
> 
>                http://www.postgresql.org/docs/faq

-- 
  Bruce Momjian  <bruce(at)momjian(dot)us>        http://momjian.us
  EnterpriseDB                             http://postgres.enterprisedb.com

  + If your life is a hard drive, Christ can be your backup. +

In response to

pgsql-patches by date

Next:From: Andrew DunstanDate: 2008-03-07 20:59:17
Subject: Re: CopyReadLineText optimization
Previous:From: Bruce MomjianDate: 2008-03-07 20:06:24
Subject: Re: [PATCHES] a tsearch2 (8.2.4) dictionary that only filters out stopwords

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group