Skip site navigation (1) Skip section navigation (2)

sinval.c / sinvaladt.c restructuring

From: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
To: Pg Patches <pgsql-patches(at)postgresql(dot)org>
Subject: sinval.c / sinvaladt.c restructuring
Date: 2008-02-29 19:39:55
Message-ID: 20080229193955.GM4673@alvh.no-ip.org (view raw or flat)
Thread:
Lists: pgsql-patches
I just modified the interactions in sinval.c and sinvaladt.c per
http://thread.gmane.org/gmane.comp.db.postgresql.devel.patches/18820/focus=18822

It looks a lot saner this way: the code that actually deals with the
queue, including locking etc, is all in sinvaladt.c.  This means that
the struct definition of the queue, and the queue pointer, are now
internal "implementation details" inside sinvaladt.c.

One side effect of this change is that the call to SendPostmasterSignal
now occurs after the lock has been released.  ISTM this is a good idea
on general principles (no syscalls in lwlocked code), but I'm wondering
if I created a thundering hoard problem that did not exist before.

All tests pass.

As a test of Review Board, I uploaded the patch to it:
http://reviewdemo.postgresql.org/r/19/

-- 
Alvaro Herrera                                http://www.CommandPrompt.com/
The PostgreSQL Company - Command Prompt, Inc.

Attachment: sinval.patch
Description: text/x-diff (21.7 KB)

Responses

pgsql-patches by date

Next:From: Robert LorDate: 2008-02-29 20:27:54
Subject: Re: DTrace probe patch for OS X Leopard
Previous:From: Peter EisentrautDate: 2008-02-29 18:57:36
Subject: Re: DTrace probe patch for OS X Leopard

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group