Skip site navigation (1) Skip section navigation (2)

pgsql: Reducing the assumed alignment of struct varlena means that the

From: tgl(at)postgresql(dot)org (Tom Lane)
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Reducing the assumed alignment of struct varlena means that the
Date: 2008-02-29 17:47:47
Message-ID: 20080229174747.A4CC6754108@cvs.postgresql.org (view raw or flat)
Thread:
Lists: pgsql-committers
Log Message:
-----------
Reducing the assumed alignment of struct varlena means that the compiler
is also licensed to put a local variable declared that way at an unaligned
address.  Which will not work if the variable is then manipulated with
SET_VARSIZE or other macros that assume alignment.  So the previous patch
is not an unalloyed good, but on balance I think it's still a win, since
we have very few places that do that sort of thing.  Fix the one place in
tuptoaster.c that does it.  Per buildfarm results from gypsy_moth
(I'm a bit surprised that only one machine showed a failure).

Tags:
----
REL8_3_STABLE

Modified Files:
--------------
    pgsql/src/backend/access/heap:
        tuptoaster.c (r1.81.2.1 -> r1.81.2.2)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/access/heap/tuptoaster.c?r1=1.81.2.1&r2=1.81.2.2)

pgsql-committers by date

Next:From: Andrew DunstanDate: 2008-02-29 18:43:23
Subject: Re: pgsql: Fix handling of restricted processes for Windows Vista (mainly),
Previous:From: Tom LaneDate: 2008-02-29 17:47:41
Subject: pgsql: Reducing the assumed alignment of struct varlena means that the

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group