Skip site navigation (1) Skip section navigation (2)

remove TCL_ARRAYS

From: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
To: Pg Patches <pgsql-patches(at)postgresql(dot)org>
Subject: remove TCL_ARRAYS
Date: 2008-02-29 14:34:14
Message-ID: 20080229143414.GE4673@alvh.no-ip.org (view raw or flat)
Thread:
Lists: pgsql-patches
This patch removes the TCL_ARRAY symbol.  This seems to be a leftover
from when pgtcl was around in the backend; if enabled, it causes
array_out to emit bogus array values:

alvherre=# create table bar ( a text);
CREATE TABLE
alvherre=# insert into bar values ('foo"');
INSERT 0 1
alvherre=# select array_append('{}', a) from bar;
 array_append 
--------------
 {"foo""}
(1 ligne)

The correct value is

alvherre=# select array_append('{}', a) from bar;
 array_append 
--------------
 {"foo\""}
(1 ligne)


Of course, the system does not accept the TCL_ARRAY value back.

-- 
Alvaro Herrera                                http://www.CommandPrompt.com/
The PostgreSQL Company - Command Prompt, Inc.

Attachment: remove-tcl-arrays.patch
Description: text/x-diff (1.1 KB)

Responses

pgsql-patches by date

Next:From: Robert LorDate: 2008-02-29 14:39:23
Subject: Re: DTrace probe patch for OS X Leopard
Previous:From: Robert LorDate: 2008-02-29 14:17:00
Subject: Re: DTrace probe patch for OS X Leopard

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group