pgsql: Fix mistakes in pg_ctl's code for "start -w" that tries to cope

From: tgl(at)postgresql(dot)org (Tom Lane)
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Fix mistakes in pg_ctl's code for "start -w" that tries to cope
Date: 2008-02-20 22:18:15
Message-ID: 20080220221815.5E30F754108@cvs.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Log Message:
-----------
Fix mistakes in pg_ctl's code for "start -w" that tries to cope with
non-default settings for the postmaster's port number. The code to parse
command line options and postgresql.conf entries wasn't quite right about
whitespace or quotes, and it was coded in a not-very-readable way too.
Per bug #3969 from Itagaki Takahiro, though this is more extensive than his
proposed patch (which fixed only the whitespace problem).
This code has been broken since it was put in in 8.0, so patch all the way
back.

Modified Files:
--------------
pgsql/src/bin/pg_ctl:
pg_ctl.c (r1.92 -> r1.93)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/src/bin/pg_ctl/pg_ctl.c?r1=1.92&r2=1.93)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2008-02-20 22:18:20 pgsql: Fix mistakes in pg_ctl's code for "start -w" that tries to cope
Previous Message Tom Lane 2008-02-20 17:44:26 pgsql: Put a CHECK_FOR_INTERRUPTS call into the loops that try to find a