Skip site navigation (1) Skip section navigation (2)

pgsql: Remove unnecessary opening of other relation in

From: tgl(at)postgresql(dot)org (Tom Lane)
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Remove unnecessary opening of other relation in
Date: 2008-02-18 23:00:32
Message-ID: 20080218230032.660D6754108@cvs.postgresql.org (view raw or flat)
Thread:
Lists: pgsql-committers
Log Message:
-----------
Remove unnecessary opening of other relation in RI_FKey_keyequal_upd_pk
and RI_FKey_keyequal_upd_fk, as well as no-longer-needed calls of
ri_BuildQueryKeyFull.  Aside from saving a few cycles, this avoids needless
deadlock risks when an update is not changing the columns that participate
in an RI constraint.  Per a gripe from Alexey Nalbat.

Back-patch to 8.3.  Earlier releases did have a need to open the other
relation due to the way in which they retrieved information about the RI
constraint, so this problem unfortunately can't easily be improved pre-8.3.

Tom Lane and Stephan Szabo

Modified Files:
--------------
    pgsql/src/backend/utils/adt:
        ri_triggers.c (r1.103 -> r1.104)
        (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/utils/adt/ri_triggers.c?r1=1.103&r2=1.104)

pgsql-committers by date

Next:From: Tom LaneDate: 2008-02-18 23:00:38
Subject: pgsql: Remove unnecessary opening of other relation in
Previous:From: Tom LaneDate: 2008-02-18 22:36:49
Subject: Re: pgsql: autoconf 2.61's AC_FUNC_FSEEKO reports success/failure

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group