Skip site navigation (1) Skip section navigation (2)

Re: [BUGS] BUG #3909: src\tools\msvc\clean.bat clears parse.h file

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: Dave Page <dpage(at)postgresql(dot)org>
Cc: Pavel Golub <pavel(at)gf(dot)microolap(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: [BUGS] BUG #3909: src\tools\msvc\clean.bat clears parse.h file
Date: 2008-02-06 15:13:42
Message-ID: 20080206151342.GG9549@svr2.hagander.net (view raw or flat)
Thread:
Lists: pgsql-bugspgsql-hackers
On Tue, Feb 05, 2008 at 09:47:16PM +0000, Dave Page wrote:
> On Feb 5, 2008 5:56 PM, Magnus Hagander <magnus(at)hagander(dot)net> wrote:
> >
> > Dave Page wrote:
> > > On Feb 5, 2008 3:24 PM, Magnus Hagander <magnus(at)hagander(dot)net> wrote:
> > >> On Mon, Jan 28, 2008 at 06:27:05PM +0000, Pavel Golub wrote:
> > >> I think a better solution is to add a parameter to clean.bat to make it
> > >> work like "make clean" does. So you'd to "clean" when you mean "make
> > >> clean", and "clean dist" when you mean "make distclean".
> > >>
> > >> Thoughts on this?
> > >
> > > Pretty sure I griped at you before about this, because when it removes
> > > it, it fails to rebuild it the next time round, even on in an env like
> > > mine which can build from CVS perfectly well. More than once I've had
> > > to unpack the tarball again having run a clean.
> >
> > Uh, that would be a different issue, and I thought that one was fixed. I
> > certainly clean/rebuild a lot, and it works just fine with the stuff
> > coming out of cvs.
> >
> > The problem comes from if you remove *one* of the files but not *all* of
> > them. We only trigger on one of them (unlike the makefile which triggers
> > on all). But as long as they are all removed, it should be ok.
> >
> > Can you confirm if you actually still have that problem with 8.3.0?
> 
> Yup - run clean.bat, and then build.bat and the resulting build fails
> because parser/parse.h is missing. Thats with the 8.3.0 tarball, which
> built just fine prior to running clean. Bison and flex are in the
> path.

Fixed version applied to HEAD.

//Magnus

In response to

pgsql-hackers by date

Next:From: Magnus HaganderDate: 2008-02-06 15:41:56
Subject: Re: pg_dump additional options for performance
Previous:From: Simon RiggsDate: 2008-02-06 15:13:24
Subject: pg_dump additional options for performance

pgsql-bugs by date

Next:From: Tom LaneDate: 2008-02-06 16:26:16
Subject: Re: Vers. 8.3.0: "make check" fails dismally
Previous:From: Pit M.Date: 2008-02-06 15:10:16
Subject: Re: BUG #3924: Create Database with another encoding as the encoding from postgres

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group