Skip site navigation (1) Skip section navigation (2)

Re: Oops - BF:Mastodon just died

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Andrew Dunstan <andrew(at)dunslane(dot)net>, Dave Page <dpage(at)postgresql(dot)org>,Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Oops - BF:Mastodon just died
Date: 2008-01-31 08:42:56
Message-ID: 20080131084256.GB8942@svr2.hagander.net (view raw or flat)
Thread:
Lists: pgsql-hackers
On Thu, Jan 31, 2008 at 12:45:40AM -0500, Tom Lane wrote:
> Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
> > Yes, I have found the problem. It is this line, which I am amazed hasn't 
> > bitten us before:
> >         next unless /^\d/;
> > The first field in the dumpbin output looks like a 3 digit hex number. 
> 
> Argh, so it was crossing a power-of-2 boundary that got us.  Good catch.
> 
> > For now I'm going try to fix it by changing it to:
> >         next unless $pieces[0] =~/^[A-F0-9]{3}$/;
> 
> Check.

Yeah, nice catch. Wouldn't surprise me if we actually had this problem
before, just that the dropped symbols were not actually used by our own
modules. I notice the export count jumped to 5226...


> > I also propose to have the gendefs.pl script save the dumpbin output so 
> > this sort of problem will be easier to debug.
> 
> Agreed, but I suggest waiting till 8.4 is branched unless you are really
> sure about this addition.  We freeze for 8.3.0 in less than 24 hours.

+1

//Magnus

In response to

Responses

pgsql-hackers by date

Next:From: Magnus HaganderDate: 2008-01-31 09:25:03
Subject: Re: 8.3RC1 on windows missing descriptive Event handle names
Previous:From: Magnus HaganderDate: 2008-01-31 08:39:55
Subject: Re: Oops - BF:Mastodon just died

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group