Skip site navigation (1) Skip section navigation (2)

Re: Bogus cleanup code in GSSAPI/SSPI patch

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers(at)postgreSQL(dot)org
Subject: Re: Bogus cleanup code in GSSAPI/SSPI patch
Date: 2008-01-29 12:14:59
Message-ID: 20080129121459.GF22065@svr2.hagander.net (view raw or flat)
Thread:
Lists: pgsql-hackers
On Mon, Jan 28, 2008 at 09:11:31PM -0500, Tom Lane wrote:
> Hi Magnus,
>   Would you take a look at the patch I just committed in fe-connect.c?
> 
> I found out today that PQreset() wasn't working on a GSSAPI connection,
> because closePGconn hadn't been patched to clear out the GSSAPI state
> (resulting in "duplicate GSS authentication request" failure).  I think
> I fixed that but it wouldn't be bad for someone who knows that code
> better to double-check.  Also, I can't test the ENABLE_SSPI case,
> so that needs to be looked at.
> 
> The test case I've been using is to "select 1;" in psql, then kill -9
> the backend from another window, then "select 1;" again.  psql should
> recover and reconnect successfully.

Looks good from here.

As for the SSPI case, it actually recovered just fine with SSPI before this
patch - from how I read it there was a memory leak, though. 

And I can confirm that it still works after this patch.

//Magnus

In response to

pgsql-hackers by date

Next:From: Euler Taveira de OliveiraDate: 2008-01-29 13:31:01
Subject: Re: [PATCHES] Proposed patch: synchronized_scanning GUCvariable
Previous:From: Peter EisentrautDate: 2008-01-29 12:06:05
Subject: Re: RFC: array_agg() per SQL:200n

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group