Re: [PATCH] Add size/acl information when listing databases

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Andrew Gilligan <andy(at)tcpd(dot)net>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: [PATCH] Add size/acl information when listing databases
Date: 2008-01-28 17:47:42
Message-ID: 200801281747.m0SHlgU24497@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


This has been saved for the 8.4 release:

http://momjian.postgresql.org/cgi-bin/pgpatches_hold

---------------------------------------------------------------------------

Andrew Gilligan wrote:
>
> On 20 Jan 2008, at 04:34, Tom Lane wrote:
> > Andrew Gilligan <andy(at)tcpd(dot)net> writes:
> >> Showing the size on \l+ probably makes more sense, but I imagine that
> >> would require a very different approach due to the permissions
> >> changes?
> >
> > I haven't experimented, but perhaps something along the lines of
> >
> > case when has_database_privilege(current_user, db.oid, 'connect')
> > then pg_database_size...
> > else null
> > end
> >
> > would fix it.
>
>
> Yep, that seems to do the trick.
>
> I've attached an updated patch (based on 8.3RC2) that adds the ACL
> information to \l and the size to \l+ if available.
>
> Best regards,
> -Andy
>
>

[ Attachment, skipping... ]

>
>
> ---------------------------(end of broadcast)---------------------------
> TIP 7: You can help support the PostgreSQL project by donating at
>
> http://www.postgresql.org/about/donate

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://postgres.enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Pavel Golub 2008-01-28 18:27:05 BUG #3909: src\tools\msvc\clean.bat clears parse.h file
Previous Message Simon Riggs 2008-01-28 17:14:39 Re: [PATCHES] Proposed patch: synchronized_scanning GUC variable