Skip site navigation (1) Skip section navigation (2)

Re: pgsql: Fix an ancient oversight in libpq'shandling of V3-protocol COPY

From: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
To: Simon Riggs <simon(at)2ndquadrant(dot)com>
Cc: Tom Lane <tgl(at)postgresql(dot)org>, pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Fix an ancient oversight in libpq'shandling of V3-protocol COPY
Date: 2008-01-15 21:22:45
Message-ID: 20080115212245.GJ4473@alvh.no-ip.org (view raw or flat)
Thread:
Lists: pgsql-committerspgsql-hackers
Simon Riggs wrote:
> On Mon, 2008-01-14 at 18:46 +0000, Tom Lane wrote:
> > Log Message:
> > -----------
> > Fix an ancient oversight in libpq's handling of V3-protocol COPY OUT mode:
> > we need to be able to swallow NOTICE messages, and potentially also
> > ParameterStatus messages (although the latter would be a bit weird),
> > without exiting COPY OUT state.  Fix it, and adjust the protocol documentation
> > to emphasize the need for this.  Per off-list report from Alexander Galler.
> 
> My reading of this is that previously a PQgetCopyData() operation would
> fail mysteriously because of 
> 
> i) a reload of postgresql.conf, following the setting of any of the
> following parameters client_encoding, DateStyle, TimeZone, and
> standard_conforming_strings.

Hmm, aren't ParameterStatus messages sent just before Ready For Query?

> ii) any previous LISTEN command on the session running the COPY

I don't think LISTEN is involved.  It's NOTICE that's a problem, not
NOTIFY.

-- 
Alvaro Herrera                                http://www.CommandPrompt.com/
The PostgreSQL Company - Command Prompt, Inc.

In response to

Responses

pgsql-hackers by date

Next:From: Simon RiggsDate: 2008-01-15 21:33:56
Subject: Re: pgsql: Fix an ancient oversight in libpq'shandling of V3-protocol COPY
Previous:From: Simon RiggsDate: 2008-01-15 21:02:42
Subject: Re: pgsql: Fix an ancient oversight in libpq'shandling of V3-protocol COPY

pgsql-committers by date

Next:From: Simon RiggsDate: 2008-01-15 21:33:56
Subject: Re: pgsql: Fix an ancient oversight in libpq'shandling of V3-protocol COPY
Previous:From: Tom LaneDate: 2008-01-15 21:20:28
Subject: pgsql: Prevent CLUSTER from decreasing a relation's relfrozenxid.

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group