Skip site navigation (1) Skip section navigation (2)

Re: Server does not start when log_statement_stats is setto on

From: Alvaro Herrera <alvherre(at)CommandPrompt(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Devrim GÜNDÜZ <devrim(at)CommandPrompt(dot)com>, pgsql-bugs(at)postgresql(dot)org
Subject: Re: Server does not start when log_statement_stats is setto on
Date: 2007-12-27 13:16:25
Message-ID: 20071227131625.GA5709@alvh.no-ip.org (view raw or flat)
Thread:
Lists: pgsql-bugs
Tom Lane wrote:

> That's getting to be a bit complicated to replicate in N places, though.
> Plus if we ever want to make it work like Alvaro is thinking of, we'd
> have to go back and change all those places again.  So I propose
> inventing a function
> 
> 	int guc_complaint_level(GucSource source)
> 
> that encapsulates this logic.

I think this makes plenty of sense.  However, something that occured to
me just now is that perhaps the right thing to do in the long term is to
put this message in errcontext and leave the "invalid value for XXX" as
the main error message.  That would probably involve attaching a
errcontext callback and removing the complaint_level from this message
altogether, letting the outer caller deal with it.  I'm not sure how
would GUC work if the assign hook did not raise an ERROR in the
interactive case though.

-- 
Alvaro Herrera                                http://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support

In response to

Responses

pgsql-bugs by date

Next:From: Alvaro HerreraDate: 2007-12-27 13:21:29
Subject: Re: BUG #3842: Service
Previous:From: Simon RiggsDate: 2007-12-27 11:27:26
Subject: Re: BUG #3843: archiver process is restarted after thesmart shutdown

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group