Skip site navigation (1) Skip section navigation (2)

Re: Server does not start when log_statement_stats is setto on

From: Alvaro Herrera <alvherre(at)CommandPrompt(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Devrim GÜNDÜZ <devrim(at)CommandPrompt(dot)com>, pgsql-bugs(at)postgresql(dot)org
Subject: Re: Server does not start when log_statement_stats is setto on
Date: 2007-12-26 18:43:07
Message-ID: 20071226184307.GC4999@alvh.no-ip.org (view raw or flat)
Thread:
Lists: pgsql-bugs
Tom Lane wrote:
> Alvaro Herrera <alvherre(at)CommandPrompt(dot)com> writes:
> > Tom Lane wrote:
> >> There are a bunch of other GUC assign hooks that behave similarly.
> >> Perhaps it'd be sensible to emit these complaints as LOG messages
> >> when we're dealing with a noninteractive source (ie, the config file)?
> 
> > I was wondering whether we could make this error message (and
> > equivalent ones) be the FATAL one that prevents the server from
> > starting.
> 
> There is some good reason, which I don't recall at the moment, why
> assign-hooks (and most of the rest of GUC) shouldn't FATAL in the
> middle of processing a config file.  However a LOG seems relatively
> harmless, and better than not emitting anything.

I'm thinking of keeping the ERROR, which (I think) would cause
postmaster to treat it as FATAL because there is no error handler set up
yet (no, I haven't tried it).

Perhaps you are correct in that LOG is the path of least resistance ...

-- 
Alvaro Herrera                                http://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support

In response to

Responses

pgsql-bugs by date

Next:From: Tom LaneDate: 2007-12-26 18:58:13
Subject: Re: Server does not start when log_statement_stats is set to on
Previous:From: Tom LaneDate: 2007-12-26 18:35:36
Subject: Re: Server does not start when log_statement_stats is set to on

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group