Skip site navigation (1) Skip section navigation (2)

Re: Server does not start when log_statement_stats is setto on

From: Alvaro Herrera <alvherre(at)CommandPrompt(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Devrim GÜNDÜZ <devrim(at)CommandPrompt(dot)com>, pgsql-bugs(at)postgresql(dot)org
Subject: Re: Server does not start when log_statement_stats is setto on
Date: 2007-12-26 17:50:24
Message-ID: 20071226175024.GA4999@alvh.no-ip.org (view raw or flat)
Thread:
Lists: pgsql-bugs
Tom Lane wrote:
> Devrim =?ISO-8859-1?Q?G=DCND=DCZ?= <devrim(at)CommandPrompt(dot)com> writes:

> > or can we please improve the error message here -- or is it a bug?
> 
> It's not a bug.  However, the specific error message only comes out in
> interactive-SET cases:
> 
>         if (source >= PGC_S_INTERACTIVE)
>             ereport(ERROR,
>                     (errcode(ERRCODE_INVALID_PARAMETER_VALUE),
>                      errmsg("cannot enable \"log_statement_stats\" when "
>                             "\"log_parser_stats\", \"log_planner_stats\", "
>                             "or \"log_executor_stats\" is true")));
> 
> There are a bunch of other GUC assign hooks that behave similarly.
> Perhaps it'd be sensible to emit these complaints as LOG messages
> when we're dealing with a noninteractive source (ie, the config file)?

I was wondering whether we could make this error message (and
equivalent ones) be the FATAL one that prevents the server from
starting.

-- 
Alvaro Herrera                                http://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support

In response to

Responses

pgsql-bugs by date

Next:From: Tom LaneDate: 2007-12-26 18:35:36
Subject: Re: Server does not start when log_statement_stats is set to on
Previous:From: Tom LaneDate: 2007-12-26 17:44:34
Subject: Re: Server does not start when log_statement_stats is set to on

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group