Re: Problem with ControlFileData structure being ABI depe ndent

From: "Magnus Hagander" <magnus(at)hagander(dot)net>
To: "Dave Page" <dpage(at)postgresql(dot)org>
Cc: "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "Gregory Stark" <stark(at)enterprisedb(dot)com>, "Rainer Bauer" <usenet(at)munnin(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Problem with ControlFileData structure being ABI depe ndent
Date: 2007-12-07 12:49:33
Message-ID: 200712071349340000@125917993
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches


> > I guess my advice would be to see if we can define _USE_32BIT_TIME_T
> > in port/win32.h and make it go away that way. It'd definitely be nice
> > if MSVC and Mingw builds weren't binary-incompatible.
>
> The attached patch defines it in the MSVC project files along with the
> other API-config related macros. It fixes all the offsets so they match
> mingw, but the CRC is still different for some as-yet unknown reason...

Is the project file really the proper place? Consider an add-on module - wouldn't we want the setting to go in that one as well? meaning we'd have it in a header file instead?

/Magnus

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Gregory Stark 2007-12-07 13:27:04 Re: Problem with ControlFileData structure being ABI depe ndent
Previous Message Hubert FONGARNAND 2007-12-07 12:40:40 Re: pg_dump and BINARY mode COPY

Browse pgsql-patches by date

  From Date Subject
Next Message Gregory Stark 2007-12-07 13:27:04 Re: Problem with ControlFileData structure being ABI depe ndent
Previous Message Gregory Stark 2007-12-07 09:15:54 Re: Proposed patch to make mergejoin cost estimation more symmetric